Skip to content

Update dependency and test command for PhantomJS - #231

Merged
davidcheung merged 1 commit into
masterfrom
phantomjs
Jul 27, 2016
Merged

davidcheung merged 1 commit into
masterfrom
phantomjs

Conversation

@davidcheung

Copy link
Copy Markdown
Contributor

connected to #215

The resolution to an error when running "npm test" is to update the PhantomJS dependency to PhantomJS2.

Background

Current angular dependency is defined:
"angular": "^1.4.9"

With the release of angular 1.5 there are errors loading angular in PhantomJS that affect this repo's default test command.

Original Issue not addressed in PhantomJS 1.0: ariya/phantomjs#10522

Recent discussion specific to angular 1.5: angular/angular.js#13794

Error Message:

PhantomJS 1.9.8 (Windows 8 0.0.0) ERROR
Error: [$injector:modulerr] Failed to instantiate module ng due to:
TypeError: 'undefined' is not an object (evaluating 'Function.prototype.bind.apply')

@davidcheung

davidcheung commented Jul 25, 2016 •

Copy link
Copy Markdown
Contributor Author

@slnode test please

@bajtos

bajtos commented Jul 27, 2016

Copy link
Copy Markdown
Member

@davidcheung LGTM, should we go ahead and land this patch?

@davidcheung
davidcheung merged commit 6e2b948 into master Jul 27, 2016
@davidcheung
davidcheung deleted the phantomjs branch July 27, 2016 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants